diff abims_xcms_fillPeaks.xml @ 3:5a54397dbc97 draft

planemo upload

--- a/abims_xcms_fillPeaks.xml	Tue Nov 24 06:26:14 2015 -0500
+++ b/abims_xcms_fillPeaks.xml	Mon Feb 22 16:40:19 2016 -0500
@@ -1,4 +1,4 @@
-<tool id="abims_xcms_fillPeaks" name="xcms.fillPeaks" version="2.0.2">
+<tool id="abims_xcms_fillPeaks" name="xcms.fillPeaks" version="2.0.5">
 
     <description>Integrate the signal in the region of that peak group not represented and create a new peak</description>
 
@@ -6,16 +6,32 @@
         <requirement type="package" version="3.1.2">R</requirement>
         <requirement type="binary">Rscript</requirement>
         <requirement type="package" version="1.44.0">xcms</requirement>
-        <requirement type="package" version="2.1">xcms_w4m_script</requirement>
+        <requirement type="package" version="2.2.0">xcms_w4m_script</requirement>
     </requirements>
     
     <stdio>
         <exit_code range="1:" level="fatal" />
     </stdio>
 
-    <command>
-        xcms.r xfunction fillPeaks image $image method $method &amp;&amp; mv fillPeaks.RData $xsetRData; cat xset.log
-    </command>
+    <command><![CDATA[
+        xcms.r 
+        xfunction fillPeaks 
+        image $image 
+
+        xsetRdataOutput $xsetRData
+
+        method $method
+
+        ###if $zip_file:
+        ##    zipfile $zip_file
+        ###end if
+        ;
+        return=\$?;
+        mv log.txt $log;
+        cat $log;
+        sh -c "exit \$return"
+        
+    ]]></command>
 
     <inputs>
         <param name="image" type="data" format="rdata.xcms.group,rdata" label="xset RData file" help="output file from another function xcms (group)" />
@@ -23,21 +39,35 @@
             <option value="chrom" selected="true">chrom</option>
             <option value="MSW" >MSW</option>
         </param>
+        <!-- To pass planemo test -->
+        <!--<param name="zip_file" type="hidden_data" format="no_unzip.zip" label="Zip file" />-->
     </inputs>
 
     <outputs>
         <data name="xsetRData" format="rdata.xcms.fillpeaks" label="${image.name[:-6]}.fillPeaks.RData" />
+        <data name="log" format="txt" label="xset.log.txt"  hidden="true" />
     </outputs>
     
     <tests>
         <test>
             <param name="image" value="xset.group.retcor.group.RData"/>
             <param name="method" value="chrom"/>
-            <output name="xsetRData" file="xset.group.retcor.group.fillPeaks.RData" />
+            <param name="zip_file" value="sacuri.zip"/>
+            <!--<output name="xsetRData" file="xset.group.retcor.group.fillPeaks.RData" />-->
+            <output name="log">
+                <assert_contents>
+                    <has_text text="object with 9 samples" />
+                    <has_text text="Time range: 0.7-1139.9 seconds (0-19 minutes)" />
+                    <has_text text="Mass range: 50.0019-999.9863 m/z" />
+                    <has_text text="Peaks: 157780 (about 17531 per sample)" />
+                    <has_text text="Peak Groups: 6761" />
+                    <has_text text="Sample classes: bio, blank" />
+                </assert_contents>
+            </output>
         </test>
     </tests>
 
-    <help>
+    <help><![CDATA[
 
         
 .. class:: infomark
@@ -172,9 +202,28 @@
     | **xset.fillPeaks.RData: RData file**
 
 
+---------------------------------------------------
+
+Changelog/News
+--------------
+
+**Version 2.0.5 - 10/02/2016**
+
+- BUGFIX: better management of errors. Datasets remained green although the process failed
+
+- UPDATE: refactoring of internal management of inputs/outputs
+
+- UPDATE: refactoring to feed the new report tool
 
 
-    </help>
+**Version 2.0.2 - 02/06/2015**
+
+- IMPROVEMENT: new datatype/dataset formats (rdata.xcms.raw, rdata.xcms.group, rdata.xcms.retcor ...) will facilitate the sequence of tools and so avoid incompatibility errors.
+
+- IMPROVEMENT: parameter labels have changed to facilitate their reading.
+
+
+    ]]></help>
 
     <citations>
         <citation type="doi">10.1021/ac051437y</citation>